react-native-reanimated icon indicating copy to clipboard operation
react-native-reanimated copied to clipboard

Remove `Animated` and `Common` symlinks

Open tomekzaw opened this issue 3 years ago • 0 comments

Description

This PR removes two symlinks:

  1. Example/Animatedsrc
  2. android/src/main/CommonCommon

These symlinks really annoyed everyone with duplicating the search results in their favourite text editor.

The Example app works fine after I removed the first symlink. 🤷‍♂️

The purpose of the second symlink was probably to compile C++ sources from Common directory along with these from android/src/main/cpp, but I'm not sure.

The PR has been tested both on Example and FabricExample app as well as fresh React Native 0.69.4 app.

After the changes, both cpp directories (Android-only and common) are properly recognized by Android Studio:

Android Studio

Debugging C++ code from Common directory in Android Studio also works correctly:

Zrzut ekranu 2022-08-12 o 18 25 21

Android Studio version: Chipmunk | 2021.2.1 Patch 1

Changes

  • Removed symlink Example/Animatedsrc
  • Removed symlink android/src/main/CommonCommon

Test code and steps to reproduce

Checklist

  • [ ] Included code example that can be used to test this change
  • [ ] Updated TS types
  • [ ] Added TS types tests
  • [ ] Added unit / integration tests
  • [ ] Updated documentation
  • [ ] Ensured that CI passes

tomekzaw avatar Aug 12 '22 16:08 tomekzaw