react-native-gesture-handler icon indicating copy to clipboard operation
react-native-gesture-handler copied to clipboard
verified publisher icon software-mansion

Fix `Gesture.Exclusive` and `onStart` not being called on web

Open j-piasecki opened this issue 3 years ago • 2 comments

Description

  • moves checking if the state has changed to happen before previousState gets overwritten, which makes GestureHandler correctly add oldState prop to events
  • updates waitFor check so that it handles getting only handlerTag, which is the case with the new API

Fixes https://github.com/software-mansion/react-native-gesture-handler/issues/2056 and https://github.com/software-mansion/react-native-gesture-handler/issues/2057.

Test plan

Tested on the Example app.

j-piasecki avatar May 18 '22 08:05 j-piasecki

any idea when this will be merged?

itsramiel avatar Jun 09 '22 14:06 itsramiel

Also ran into this issue and would be grateful if the solution could be merged provided it passes checks.

KrasniqiR avatar Jun 24 '22 13:06 KrasniqiR

Gesture Handler 2.10.0 uses the new implementation by default, where this problem doesn't exist.

j-piasecki avatar May 17 '23 10:05 j-piasecki