softvar
[WIP] [NOT MAINTAINED] Show image thumbnail functionality implemented
@softvar i have implemented the functionality to show image thumbnails for #22 . I am not supporting svg for now and also set the limit to max 100 images in directory. So if there are more than 100 images(not total files) than no preview will be visible. Please have a look if its right way to do it. Screenshot: https://prnt.sc/kdax67
Hey @manishsaraan This is simply awesome. I have seen your changes and look good to me. Once I'll be done running these changes on my local machine, I'll surely ping here with the review changes. if any.
Also, please excuse me for the changes I recently did regarding logo and disclaimer changes. I didn't notice your changes before it and hence there are some conflicts which need to be resolved in this PR.
Awesome work @manishsaraan 👍
It would be great if this feature can be toggled. In options.hmtl, there should be an option to toggle this thumbnail feature. It would help users who don't want it because of extra data consumption or because of the extra height each row is taking.
Otherwise, it's perfect.
Thanks for feedback @softvar . I will add enable thumbnail option in option.html and it will be disabled by default. Also do i need to update the current text for setting from Add Github Token to some other text as we are not only adding token there?
I would rather say thumbnail should be enabled by default and show a tooltip on hover that you can disable this in options otherwise no one would be aware of such a good feature. Regarding options.html, I would suggest having another section below "Add Github Token". Something like: [checkbox] - "Toggle image thumbnails". What do you say?
@softvar its been while since I last updated this pr. I need to review changes again and will raise pr asap.