shiplift `LogsOptions` defaults are invalid

If you rely on the defaults for LogsOptions, the request returns a 400 Bad Request with the message "bad parameter".

I would suggest removing the #[derive(Default)] and implementing it manually to provide sane defaults. I haven't tested the other Options structs but I would imagine that one or two of them are afflicted with the same problem.

Jan 18 '17 12:01 itpetey

Is this still valid on current master?

Mar 06 '21 07:03 matthiasbeyer

Considering the code doesn't seem to have changed, I would assume so https://github.com/softprops/shiplift/blob/95beb6f2aaf36d38ca1dc3abb7544fb878c45ca0/src/builder.rs#L1266-L1270

Mar 07 '21 02:03 elihunter173

So from what I see, the defaults in the docker API (https://docs.docker.com/engine/api/v1.41/#operation/ContainerLogs) and our "defaults" are not the same, but because our defaults are no options, the docker endpoint defaults should take effect, right?

Not sure whether this is intentional, but lets assume it is.

The code in 0.7.0 has no obvious issues from what I can see... so I'm not sure whether this was just an edge case in an old docker version (the API for 1.41 does not report that 400 can be returned at all for this endpoint) or whether this is actually our bug?

I propose to wait until @petehayes102 reconfirms the issue or wait 2 weeks if they do not and then closing this issue.

Mar 07 '21 08:03 matthiasbeyer