php-cross-domain-proxy icon indicating copy to clipboard operation
php-cross-domain-proxy copied to clipboard

Do not respond with 200 OK if proxied request fails

Open avbentem opened this issue 5 years ago • 0 comments

Currently fatal errors such as invalid domains simply return 200 OK. To mitigate that one could, e.g., throw 502 Bad Gateway instead.

Change:

// retrieve response (headers and content)
$response = curl_exec($ch);
curl_close($ch);

...into:

// retrieve response (headers and content)
$response = curl_exec($ch);
if ($response === false) {
    http_response_code(502);
    echo 'Failed to proxy to ' . $request_url . ': ' . curl_error($ch);
    curl_close($ch);
    exit();
}
curl_close($ch);

avbentem avatar Dec 23 '20 10:12 avbentem