Frank

Results 471 comments of Frank

Hi, why would you want to change effects ~5 times per second? Are your eyes even fast enough to recognise the running effect? If you want something like a strobe,...

Hi, I've played with LTO some time ago, and actually ran into some issues: * it did not seem to be reliable / stable on all supported devices (especially -C3...

This might be interesting, too https://github.com/platformio/platform-espressif32/pull/702

Another thing that I remember: the arduino-esp32 build scripts have an explicit "-fno-lto" https://github.com/espressif/arduino-esp32/blob/75b7f4b646599426e92ebec913a4dce14ef528cd/tools/platformio-build-esp32.py#L84 so you might also need `build_unflags = -fno-lto` to remove the no-lto flag from the command...

> Do you have any references for the a loss in performance? (that should be repro'd with a current compiler & reported upstream) AFAIK, LTO eliminates call overhead and dead...

> Do you have any suggestions on how to make things optional? I can't see a nice way to conditionally fiddle the flags. I think the script that changes `elf-ar`...

@deece ... so instead of modifying the `[common]` section, it seems more appropriate to have the lto flags/unflags one level deeper, in these sections: https://github.com/Aircoookie/WLED/blob/acf6736afdc579e0bb498b9111e2b8ff7cbaab63/platformio.ini#L230 https://github.com/Aircoookie/WLED/blob/acf6736afdc579e0bb498b9111e2b8ff7cbaab63/platformio.ini#L250 https://github.com/Aircoookie/WLED/blob/acf6736afdc579e0bb498b9111e2b8ff7cbaab63/platformio.ini#L269 https://github.com/Aircoookie/WLED/blob/acf6736afdc579e0bb498b9111e2b8ff7cbaab63/platformio.ini#L306

> I just used the version you linked for the Debug version. Previously I was loading https://github.com/Aircoookie/WLED/releases/download/v0.15.0-b2/WLED_0.15.0-b2_ESP32.bin which exhibits the issue. I don't think that's the Audioreactive version. I agree...

... plus there is the [RTC usermod](https://github.com/Aircoookie/WLED/tree/main/usermods/RTC). Just make a custom build with RTC usermod, attach a DS3231 or DS1307 module to I2C, and your WLED will take the time/date...

What's the added value of this PR? Also it seems you modified some integrity hashes, can you point us to the sites where we can verify the new hashes? Just...