SOFAtoolbox icon indicating copy to clipboard operation
SOFAtoolbox copied to clipboard

upgrade for MultiSpeakerBRIR

Open petibub opened this issue 3 years ago • 2 comments

Implement in SOFAupgradeConventions() an automatic upgrade of MultiSpeakerBRIR files to SingleRoomSRIR.

Example for such a file: http://sofacoustics.org/data/database/sbsbrir/SBSBRIR_x-0pt5y-0pt5.sofa or http://sofacoustics.org/data/database/thk/BRIR_CR1_KU_MICS_L.sofa

petibub avatar Sep 20 '22 15:09 petibub

@petibub MultispeakerBRIR uses the FIRE data type and SingleRoomSRIR uses FIR. I don't see how the upgrade can work and would suggest to upgrade to SingleRoomMIMOSRIR instead.

f-brinkmann avatar Oct 10 '22 06:10 f-brinkmann

Thank you; I updated the recommendation on sofaconventions.org.

The automatic upgrade will follow with its milestone.

isfmiho avatar Oct 18 '22 08:10 isfmiho

In https://github.com/sofacoustics/SOFAtoolbox/tree/master/SOFAtoolbox/test you can find a converter function doing so.

Should it be implemented in SOFAupgradeConventions() and run by default?

isfmiho avatar Dec 05 '22 08:12 isfmiho

Yes, that would be great, i.e., I start SOFAupgradeConventions with the deprecated MultiSpeakerBRIR dataset and SOFAupgradeConventions outputs a valid SingleRoomSRIR dataset.

petibub avatar Dec 15 '22 17:12 petibub

Implemented in SOFA Toolbox v2.1.5 (development branch).

Keep in mind that the function SOFAupgradeConventions() is not called during SOFAload and SOFAsave by default.

isfmiho avatar Dec 23 '22 09:12 isfmiho