kClust icon indicating copy to clipboard operation
kClust copied to clipboard

Please fix the bugs in mkaln.cpp

Open zhujianwei31415 opened this issue 9 years ago • 3 comments

When I recompile the kCluster binaries by using g++, I come across some problems.

The first one is that the boost library has change from -lboost_regex-mt to -lboost_regex, and I have fix it by changing Makefile.

The second one is the redeclaration of 'int i' in mkaln.cpp. I find that you first declare "size_t i" in for loop and then you declare int i = 1 in the for body. So how to fix the second bug? Can I fix it by deleting "int i = 1"?

The errrors: mkaln.cpp:85:7: error: redeclaration of 'int i' int i = 1; mkaln.cpp:295:7: error: redeclaration of 'int i' int i = 1;

zhujianwei31415 avatar May 24 '16 06:05 zhujianwei31415

ping @martin-steinegger

croth1 avatar May 29 '16 12:05 croth1

Disclaimer: kClust is not supported anymore and only avaiable for historic reasons. We developed a new clustering method called MMseqs, which is faster and more sensitve. I would recommend you to switch to MMseqs: https://github.com/soedinglab/MMseqs.

With that said, I checked the lines 85 and 295, they are in totally different scopes. Do you mean mkaln.cpp:235:7 and mkaln.cpp:295:7?

martin-steinegger avatar May 30 '16 11:05 martin-steinegger

@martin-steinegger

Thanks for your recommendation and I will have a try for MMseqs.

With that said, I mean that there are two same incompatible parts.

Part 1 mkaln.cpp:45:7 for( size_t i=start_index; i<=clu.dbsize; ++i){ vs mkaln.cpp:85:7 int i = 1;

Part 2 mkaln.cpp:235:7 for( size_t i=start_index; i<=clu.dbsize; ++i){ vs mkaln.cpp:295:7 int i = 1;

zhujianwei31415 avatar May 30 '16 12:05 zhujianwei31415