soda-php icon indicating copy to clipboard operation
soda-php copied to clipboard

Various feedback from @allejo

Open chrismetcalf opened this issue 9 years ago • 0 comments

  • [ ] composer.json should probably be updated with the new PHP requirement
  • [ ] unless you're mixing PHP with another language, the closing "?>" at the end of the file isn't necessary.
  • [ ] do you intend to expose Socrata::create_query_url and Socrata::create_curl_handle publically? if not, they can be private or protected
  • [ ] regarding phpunit, you're relying on whatever's installed on the tester's computer which may not be the same version you're using
  • [ ] When would the constructor return false? https://github.com/socrata/soda-php/blob/master/public/socrata.php#L24 if something isn't configured correctly in the constructor then an exception should be thrown instead

chrismetcalf avatar Sep 21 '16 02:09 chrismetcalf