io-event icon indicating copy to clipboard operation
io-event copied to clipboard

Hanging tests on some platforms

Open ahorek opened this issue 2 years ago • 2 comments

truffleruby, jruby and windows builds hangs here https://github.com/socketry/io-event/blob/main/lib/io/event/selector/select.rb#L173

could it be intentional because of missing WNOHANG support on these platforms? https://github.com/socketry/io-event/pull/95 I'm not familiar with the code around Fibers :)

ahorek avatar Feb 13 '24 11:02 ahorek

Windows is hanging because in general, non-blocking IO on Windows is inconsistently implemented. We probably need to improve the support in CRuby itself and skip the tests that are failing here.

ioquatix avatar Feb 14 '24 04:02 ioquatix

skipping broken tests on Windows is fine for me since I don't have any issues with real apps. I was just concerned about failing CI...

ahorek avatar Feb 14 '24 13:02 ahorek

CI is now passing, except for JRuby and TruffleRuby which have test failures.

ioquatix avatar Oct 05 '24 22:10 ioquatix