io-event icon indicating copy to clipboard operation
io-event copied to clipboard
verified publisher icon socketry

Improve URing tests

Open bruno- opened this issue 3 years ago • 2 comments

This PR is a work in progress. It improves tests for URing, which are failing when these changes are applied.

I think improving the existing test suite is a good first step. I can add more tests later. Feedback is appreciated.

Types of Changes

  • Test improvements

Testing

  • This PR makes the test suite more robust.

bruno- avatar Mar 14 '22 21:03 bruno-

I'm really happy to have expanded tests for io_uring and run this on GitHub actions if possible. If this is as easy as installing the io_uring library, I completely approve it.

ioquatix avatar Mar 14 '22 23:03 ioquatix

Do you mind rebasing this on HEAD?

ioquatix avatar Aug 21 '23 09:08 ioquatix

Thanks for your effort. We now have extensive io_uring tests.

ioquatix avatar Oct 05 '24 00:10 ioquatix

I've copied some of the test changes to main, and I wanted to report back as to the test failures you were seeing. Because io.seek and io_read/io_write can race, the test needs to be sequenced.

https://github.com/socketry/io-event/blob/795d143c115b314880f6a455e7b180b7b0f55a92/test/io/event/selector/file_io.rb#L34-L44

Ideally, we'd use pread/pwrite, but I don't expose those yet.

ioquatix avatar Oct 05 '24 00:10 ioquatix