cloudflare icon indicating copy to clipboard operation
cloudflare copied to clipboard

async-http upgrade breaks connection

Open sailing opened this issue 2 years ago • 4 comments

Hi, thanks for the great gem.

This is less an issue, more a warning.

Today we updated another gem that bumped async-http from 0.59.3 to 0.59.5.

After which we began getting No route for that URI (Code: 7000) errors from Cloudflare. It appeared for some reason the upgrade forced the cloudflare gem to begin calling /client/zones instead of /client/v4/zones.

We downgraded async-http back to 0.59.3 and everything began to work again.

sailing avatar Feb 08 '23 18:02 sailing

Thanks this is a helpful report. It's due to being more strict in the path handling (according to the URI spec rather than the "file system" behaviour), but I'll need to check this, as if it's a breaking change I might revert it.

ioquatix avatar Feb 08 '23 20:02 ioquatix

Okay, this is fixed by protocol-http v0.24.1. The behaviour for this particular method was not intended to be changed from the default. I've also added more tests and will add more external tests. Can you please test it?

ioquatix avatar Feb 10 '23 22:02 ioquatix

We are having this issue in production and this had a big impact on our business. A proper fix will be welcome! ty

julienchabanon avatar Feb 13 '23 21:02 julienchabanon

Apologies, do you mind testing the latest release? The original behaviour was restored and tests to prevent future regressions have been added.

ioquatix avatar Feb 13 '23 21:02 ioquatix

This should be fixed with the latest release. Please feel free to report back if you face further issues.

ioquatix avatar Sep 13 '24 02:09 ioquatix