cloudflare icon indicating copy to clipboard operation
cloudflare copied to clipboard

origin certificates setup and back-end CIDRs list; NO SPECS

Open costa opened this issue 4 years ago • 6 comments

Description

Support for:

  • origin certificates (securing connection from cloudflare to the origin server)
  • back-end CIDRs (restricting the origin server's access to cloudflare back end only)

Types of Changes

  • New feature.

Testing

  • [ ] I added tests for my changes.
    • and I'd like to add tests, but couldn't figure the test setup, so this is a draft PR
      • I usually have bin/test that runs the suite in a dockerised environment
  • [x] I tested my changes in production.
    • and it worked perfectly

costa avatar Oct 03 '21 20:10 costa

@9mm I understand that you might be the owner of this gem now. Thank you for your work!

If you can review this draft PR and comment on what should be done in order to merge it -- in addition to resolving the conflicts, of course -- I'll do that -- I've been using this functionality in production for many years now.

costa avatar Jul 01 '25 22:07 costa

hey it is actually @ioquatix

9mm avatar Jul 01 '25 22:07 9mm

Can you rebase it on main and let's try to implement some tests.

ioquatix avatar Jul 02 '25 00:07 ioquatix

@ioquatix oh-oh, even before the new tests, some old tests are failing; could you help me make sense of https://github.com/costa/cloudflare/actions/runs/16102570476/job/45433595059 Thank you FYI, in my production (with this specific functionality used) so far, it works.

costa avatar Jul 06 '25 20:07 costa

Yeah, I will spend some time trying to untangle this, this week. CI for this gem is complicated because it runs proper integration tests, but that sometimes has issues.

ioquatix avatar Jul 07 '25 04:07 ioquatix

@ioquatix ping ;)

costa avatar Aug 20 '25 12:08 costa