engine.io-client-java icon indicating copy to clipboard operation
engine.io-client-java copied to clipboard
verified publisher icon socketio

Upgrade to OkHttp 4.10.0, fixes #112

Open asghol opened this issue 3 years ago • 3 comments

OkHttp 3 and 4 are supposed to be fairly compatible according to OkHttp themselves. I do see some SocketException entries when running the tests. The test go green however and I've intercepted some of the tests to make sure that the test is not flakey with good results.

I'm still new to this project though so be critical.

References: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/

asghol avatar Jun 22 '22 14:06 asghol

OkHttp 3.13.x+ targets Java 8 byte code...

asghol avatar Jun 29 '22 12:06 asghol

@asghol thanks for the PR :+1:

I think we will indeed need to drop support for Java 7 and create a new major version. Let me triage a few more issues in the Java client and we will proceed :rocket:

darrachequesne avatar Jun 29 '22 12:06 darrachequesne