fix: project name when using assets-project-name flag

[37IulianPopovici]

Pull Request Submission

The pull request must:

• Reviewer Documentation
  • [X] follow CONTRIBUTING rules
  • [X] be accompanied by a detailed description of the changes
  • [X] contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
  • [X] highlight breaking API if applicable
  • [X] contain a link to the automatic tests that cover the updated functionality.
  • [X] contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
  • [X] link to the link to the PR for the User-facing documentation
• User facing Documentation
  • [X] update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
  • [X] ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
• Testing
  • [X] Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged. The review process of the code PR should include code review, testing, and any necessary feedback or revisions. Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible. Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR by our content writers.

What does this PR do?

Fixes a bug regarding the usage of the --assets-project-name flag Without this fix, when using the above flag, the name of the monitored project it's going to be: {{ProjectNameFromAssetsJsonFile}}:{{targetFile}}, which is the default behaviour. With this fix, when using --assets-project-name flag flag, project name will be: {{ProjectNameFromAssetsJsonFile}}

Risk assessment

Even though project naming is a sensible place, this PR is not imposing any risk. The flag it's only used for dotnet projects.

Where should the reviewer start?

How should this be manually tested?

For manual testing, this fixture can be used along with snyk monitor --assets-project-name

Any background context you want to provide?

Client is complaining that --assets-project-name flag it's broken since CLI v.1.1225.0. That version included a fix for project naming along multiple ecosystems, but never for the --assets-project-name flag

What are the relevant tickets?

SUP-2285

Screenshots

Additional questions

[github-actions[bot]]

	Warnings
:warning:	Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones. A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax. Files found: src/cli/commands/monitor/index.ts

Generated by :no_entry_sign: dangerJS against 37b3551e3410c376358954e859600ea81f1de319

[PeterSchafer]

@37IulianPopovici closing this stale PR. Please re-open if necessary.

[37IulianPopovici]

Reopened: we will get this merged after sending an announcement to all customers that use the --assets-project-name flag