spike: add makeAsyncRequest

Open jk05 opened this issue 3 years ago • 1 comments

[ ] Follows CONTRIBUTING rules

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

Aug 11 '22 16:08 jk05

Fails

:no_entry_sign:
"wip" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.

:no_entry_sign:
"spike: add makeAsyncRequest wrapper, thinking around error handling and timeouts" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.

:no_entry_sign:
"spike: add makeAsyncRequest" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.

Warnings

:warning:
Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones. A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax. Files found:

src/lib/request/index.ts

src/lib/request/request.ts

:warning:
You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

:warning:
"spike: add makeAsyncRequest wrapper, thinking around error handling and timeouts" is too long. Keep the first line of your commit message under 72 characters.

	Fails
:no_entry_sign:	"wip" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
:no_entry_sign:	"spike: add makeAsyncRequest wrapper, thinking around error handling and timeouts" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
:no_entry_sign:	"spike: add makeAsyncRequest" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.

	Warnings
:warning:	Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style `import`s and `export`s to ES6 ones. A file you've modified is using either `module.exports` or `require()`. If you can, please update them to ES6 import syntax and export syntax. Files found: `src/lib/request/index.ts` `src/lib/request/request.ts`
:warning:	You've modified files in `src/` directory, but haven't updated anything in test folder. Is there something that could be tested?
:warning:	"spike: add makeAsyncRequest wrapper, thinking around error handling and timeouts" is too long. Keep the first line of your commit message under 72 characters.

Generated by :no_entry_sign: dangerJS against 8c09893731eb191b4a6b1fe4b1c66b9fc8d80bcd

Aug 11 '22 16:08 github-actions[bot]