snowpark-python icon indicating copy to clipboard operation
snowpark-python copied to clipboard

SNOW-654839: Additional regression test for save_as_table

Open sfc-gh-hachouraria opened this issue 3 years ago • 1 comments

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-654839

  2. Fill out the following pre-review checklist:

    • [x] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Attempting to save a new dataframe created out of a SELECT * result failed in 0.8.0 but was fixed by SNOW-619431 inadvertently.

    This change adds an additional test covering a scenario where a bulk insert is made from data collected through a SELECT * query (no columns specified).

    This is a test-only change. It makes no changes to any library or API files.

    Testing notes:

    • Ran all of the test suites via pytest
    • Newly added unit test passes on main
    • Verified manually that the unit test also:
      • Passes on tag 0.7.0
      • Fails on tag 0.8.0
      • Passes on tag 0.9.0

    Signature of failure on tag 0.8.0 matches the reported issue in SNOW-654839:

    FAILED tests/integ/scala/test_dataframe_suite.py::test_write_from_collected_dataframe - TypeError: argument of type 'NoneType' is not iterable
    

sfc-gh-hachouraria avatar Sep 01 '22 06:09 sfc-gh-hachouraria

Hi @sfc-gh-yixie, could you please help review this test-only addition?

sfc-gh-hachouraria avatar Sep 01 '22 07:09 sfc-gh-hachouraria