snowpark-python icon indicating copy to clipboard operation
snowpark-python copied to clipboard

SNOW-1748403: Use Aggregate.aggregate_expressions to infer quoted identifiers

Open sfc-gh-jdu opened this issue 1 year ago • 2 comments

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1748403

  2. Fill out the following pre-review checklist:

    • [x] I am adding a new automated test(s) to verify correctness of my new code
      • [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am adding new credentials
    • [ ] I am adding a new dependency
    • [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • [x] I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    We can use Aggregare.aggregate_expressions directly for quoted identifiers

sfc-gh-jdu avatar Oct 28 '24 22:10 sfc-gh-jdu

This looks great. Is there a way to quantify the impact of each of those improvements on the reduction of describe queries?

sfc-gh-helmeleegy avatar Oct 28 '24 23:10 sfc-gh-helmeleegy

This looks great. Is there a way to quantify the impact of each of those improvements on the reduction of describe queries?

Yeah I was using sql counter on some modin tests to see the impact. For example, test_describe_numeric_only will reduce 6 describe query with this change. I also tried to run workload tests in https://github.com/snowflakedb/snowpark-pandas-internal, and I can use my own branch to check the number of describe queries.

sfc-gh-jdu avatar Oct 28 '24 23:10 sfc-gh-jdu