SNOW-1748403: Use Aggregate.aggregate_expressions to infer quoted identifiers
-
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1748403
-
Fill out the following pre-review checklist:
- [x] I am adding a new automated test(s) to verify correctness of my new code
- [ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
- [ ] I am adding new logging messages
- [ ] I am adding a new telemetry message
- [ ] I am adding new credentials
- [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
- [x] I am adding a new automated test(s) to verify correctness of my new code
-
Please describe how your code solves the related issue.
We can use Aggregare.aggregate_expressions directly for quoted identifiers
This looks great. Is there a way to quantify the impact of each of those improvements on the reduction of describe queries?
This looks great. Is there a way to quantify the impact of each of those improvements on the reduction of describe queries?
Yeah I was using sql counter on some modin tests to see the impact. For example, test_describe_numeric_only will reduce 6 describe query with this change. I also tried to run workload tests in https://github.com/snowflakedb/snowpark-pandas-internal, and I can use my own branch to check the number of describe queries.