snowflake-connector-python icon indicating copy to clipboard operation
snowflake-connector-python copied to clipboard

Remove dependencies on Cryptodome and oscrypto

Open sfc-gh-sfan opened this issue 2 years ago • 2 comments

The code to use cryptography (which uses OpenSSL) already existed, but it just wasn't being used by default. Since cryptography is currently a mandatory dependency, we may as well use it all the time.

Partially resolves #1605/SNOW-843716.

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • [ ] I am adding a new automated test(s) to verify correctness of my new code
    • [ ] I am adding new logging messages
    • [ ] I am adding a new telemetry message
    • [ ] I am modifying authorization mechanisms
    • [ ] I am adding new credentials
    • [ ] I am modifying OCSP code
    • [ ] I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-sfan avatar Oct 04 '23 16:10 sfc-gh-sfan

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


2 out of 3 committers have signed the CLA.
:white_check_mark: (sfc-gh-sfan)[https://github.com/sfc-gh-sfan]
:white_check_mark: (sfc-gh-jdu)[https://github.com/sfc-gh-jdu]
:x: @geofft
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Oct 04 '23 16:10 github-actions[bot]

@geofft I think the linters are still failing, and requires CLA?

kpark-hrp avatar Oct 10 '23 21:10 kpark-hrp