python-goto icon indicating copy to clipboard operation
python-goto copied to clipboard
verified publisher icon snoack

Fixed and tested for 3.8

Open fadein opened this issue 5 years ago • 3 comments

fadein avatar Feb 05 '20 06:02 fadein

This merge request seems incomplete. It doesn't add Python 3.8 to tox.iniand .travis.yml, and the changes break on other Python versions (see the CI status).

snoack avatar Feb 05 '20 08:02 snoack

@snoack - did you give up on my pull requests already? As you recall, #28 provides stable py38 support, together with stabler support for other py versions (less crashes/bugs/etc, with tests).

insignification avatar Feb 06 '20 23:02 insignification

EDIT: ignore the comment below, I see the code.co_kwonlyargcount fix was already introduced here: https://github.com/snoack/python-goto/blame/acbe736221d2238df3d09beab457d0bb19d05812/goto.py#L55

OUTDATED COMMENT: Ah! Was going to create a similar PR. Discovered the same fix. (the extra code.co_kwonlyargcount parameter in 3.8) @snoack, please consider looking at this PR again :pray:

rh314 avatar Oct 11 '20 10:10 rh314