snapcore
Logout/profile support
Marked as WIP since I need to put back the macaroon handling in snapweb & via SSO and investigate the "hand off to snapd",
The branch has been updated to remove the login steps and account for a command line login option
Ok, so I finally tested this.
This works as advertised, ie I was able to login, logout, see my profile.
I noticed the following issues as a user (ie not code issues). I mention here for the record. This will require other branches for most of those :
- the logout link is not aligned with the rest of the text
- i needed to refresh the profile page once logged in from the command line (need a poll mechanism, like for installing snaps)
- installing snaps is broken with this branch, either when logged in, or not
- if not logged in i would expect not to be able to install snaps
- when logged in, i would like to see my avatar ;) ie http://www.gravatar.com/avatar/' + md5(email));
- the profile tab layout is not great, would need some visual design love
@dbarth:
the logout link is not aligned with the rest of the text
right will fix it,
i needed to refresh the profile page once logged in from the command line (need a poll mechanism, like for installing snaps)
yes, but I did not want to add something like that that would become obsolete as soon as we add the explicit login state.
Thinking about it, ... it would actually be handy, maybe not using polling, but a better mechanism, since we have a dual login mechanism (command line & web),
installing snaps is broken with this branch, either when logged in, or not
checking,
if not logged in i would expect not to be able to install snaps
no, when not logged in you can still install snaps locally, the login bit allows you to see your private snap. But at the system (snapd) level there is no login requirement to install snaps,
when logged in, i would like to see my avatar ;) ie http://www.gravatar.com/avatar/' + md5(email));
ah ! yes,
the profile tab layout is not great, would need some visual design love
yes, it is pretty empty atm, and there is a "bug" at the snapd level that prevents us from getting a meaningful user name,
I updated the PR with some fixes, I can properly install snaps though. Some snaps fail during install (even with the snap command line) though, like 'avahi' and 'asciinema' make sure you dont test with those. The error reporting for snap install failures and even for weird snap issues (like avahi that seems to unlink during snap install) is bad at the moment. I'll add bugs for those,