many: apparmor prompting meta-PR

[olivercalder]

This is the meta-PR to track outstanding changes from the prompting branch. Smaller PRs will be opened to chip away at these differences, with the eventual goal of bringing full apparmor prompting functionality into snapd.

[olivercalder]

Fixed the CLA check by adding a mapping from [email protected] to [email protected] in .mailmap. This only applies to new commits, so no previous commits will be affected. After the prompting work is merged, this change could be reverted, in case Zygmunt re-connects [email protected] to their GutHub or Launchpad accounts and adds commits to snapd in the future.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 62.61567% with 606 lines in your changes are missing coverage. Please review.

Project coverage is 78.65%. Comparing base (199386c) to head (c379f69).

Files	Patch %	Lines
overlord/ifacestate/apparmorprompting/prompting.go	12.22%	227 Missing and 10 partials :warning:
daemon/api_prompting.go	0.00%	187 Missing :warning:
...ate/apparmorprompting/requestrules/requestrules.go	80.22%	67 Missing and 21 partials :warning:
overlord/ifacestate/ifacemgr.go	43.93%	35 Missing and 2 partials :warning:
overlord/configstate/configcore/prompting.go	31.25%	20 Missing and 2 partials :warning:
...lord/ifacestate/apparmorprompting/common/common.go	96.12%	13 Missing and 4 partials :warning:
overlord/ifacestate/handlers.go	0.00%	13 Missing :warning:
interfaces/builtin/home.go	66.66%	2 Missing and 1 partial :warning:
...apparmorprompting/requestprompts/requestprompts.go	98.59%	2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #12964      +/-   ##
==========================================
- Coverage   78.84%   78.65%   -0.20%     
==========================================
  Files        1043     1050       +7     
  Lines      134505   136122    +1617     
==========================================
+ Hits       106050   107064    +1014     
- Misses      21845    22409     +564     
- Partials     6610     6649      +39     

Flag	Coverage Δ
unittests	78.65% <62.61%> (-0.20%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[olivercalder]

I'm not sure why the CLA check is failing again... all commits under Zygmunt have been mapped to me(at)zygoon(dot)pl, and the only new-ish commit which is authored by zygmunt.krynicki(at)canonical(dot)com is 4d01b69eb810760315cdb25e87a1c1b8be9a3a68 , which already appears in master as well. It would be nice if the CLA checker indicated which commit caused the failure, I may have to adjust it and see if I can figure that out. Commit sign-offs should not be the problem.

Edit: in the PR to backport the listener into snapd master (https://github.com/snapcore/snapd/pull/13148), I ran git commit --amend --reset-author on the initial commit for this PR, and that solved the CLA issue. I will fix this in this PR when I rebase the prompting branch on master after the listener package has been merged into master.

[olivercalder]

Skipping spread for now so commits to the prompting branch don't waste test runner resources.

[olivercalder]

The remaining changes from this PR will be applied in new PRs on top of snapd master. The current state of this branch will be preserved in https://github.com/olivercalder/snapd/tree/prompting-archive