bundle-analyzer icon indicating copy to clipboard operation
bundle-analyzer copied to clipboard

Github check does not appear

Open skjnldsv opened this issue 6 years ago • 9 comments

Hey!

Thanks for your awesome app, looks very promising! https://github.com/skjnldsv/vueexample/pull/237/checks

Just enabled this, and I can see the results just fine https://app.bundle-analyzer.com/gh/skjnldsv/vueexample But there is no github checks on my pull requests. Anything I need to do?

skjnldsv avatar Oct 02 '19 10:10 skjnldsv

Everything fine, just make a new pull-request and it should show up.

gregberge avatar Oct 02 '19 10:10 gregberge

I did already, it doesn't :) https://github.com/skjnldsv/vueexample/pull/261

skjnldsv avatar Oct 02 '19 10:10 skjnldsv

@neoziro My guess is the bundle analyzer don't understand it comes from a pull request against master and not a merge. The result on https://app.bundle-analyzer.com/gh/skjnldsv/vueexample/builds/8 show the branch is master, but it's not.

Capture d’écran_2019-10-02_12-42-34 Capture d’écran_2019-10-02_12-42-40

skjnldsv avatar Oct 02 '19 10:10 skjnldsv

Reopen? :)

skjnldsv avatar Oct 02 '19 16:10 skjnldsv

Hello @skjnldsv, so what is the problem exactly? Let's fix it!

gregberge avatar Oct 18 '19 20:10 gregberge

When opening a new pr, there is no GitHub checks for me :/ Do I need to configure something more? :)

Also it looks like all pr are displayed as master commits instead of the current branch of the commit (see previous comment)

skjnldsv avatar Oct 19 '19 07:10 skjnldsv

If I go to https://app.bundle-analyzer.com/gh/nextcloud/mail/builds I see only builds on master, though most are from PRs. Same wrong info at https://app.bundle-analyzer.com/gh/nextcloud/mail/builds/358

Branch master

Do we miss any configuration? How's the branch determined?

ChristophWurst avatar Oct 23 '19 08:10 ChristophWurst

Is it maybe because we use an organization? @gregberge have you tested with such a repo?

ChristophWurst avatar Dec 09 '19 19:12 ChristophWurst

Hey guys, same happens for us. I'm trying to integrate your solution into our organisation. But GitHub checks is stale in waiting status despite finished job.

image

image

gotbahn avatar Dec 27 '19 20:12 gotbahn