developer icon indicating copy to clipboard operation
developer copied to clipboard

Dev

Open chriscarrollsmith opened this issue 2 years ago • 0 comments

Changes:

  1. There's a bug in the VSCode devcontainers extension that causes it to fail to interpret end-of-line comments as comments in the dockerfile. This was causing Docker container build to fail. I moved the comments to their own lines, and it fixed the issue.

  2. The .devcontainer.json file was incorrectly formatted, so I fixed the JSON hierarchy for "build" and "settings". (The terminal setting is still using a deprecated format, but I left that one because it's non-breaking and I wanted to leave a minimal footprint.)

  3. I clarified in the README that the dockerfile doesn't set up modal, so you'll have to set up modal in the container yourself.

  4. I added python-dotenv as a dependency and added load_dotenv() statements to the modules users can call.

  5. I edited the dockerfile so that it optionally copies any .env file over to the Docker container.

chriscarrollsmith avatar Jun 02 '23 19:06 chriscarrollsmith