smc
Remove 0x09CD as keyspec_comma for as_IN and bn_IN keyboards
Hi SMC Team,
This is my 3rd PR for Indic Keyboard. Feeling great to contribute.
Anyway, for the latest release, I found that the "Bengali - Probhat" layout has a wrong key instead of Comma , (right beside the language switch key). The character 0x09CD (BENGALI SIGN VIRAMA) is used to join two or more characters into a single composite character which is obviously not a comma key.
This PR fixes the wrongly places comma for as_IN and bn_IN layout.
Hi @mdminhazulhaque, Thanks for the PR.
The file you have modified is auto generated. It is mentioned at the top of the file.
It is generated from tools/make-keyboard-text/res/values-*.
Please make necessary changes and update the PR.
One more thing, if you are not aware, we moved development to gitlab. If you can send future updates there, that'll also be helpful - https://gitlab.com/indicproject/indic-keyboard/
@mdminhazulhaque can you also make sure this change won't affect other layouts in as_IN and bn_IN, as in make sure the virama sign can be entered in some way in other layouts.
Hi @jishnu7 thanks for the suggestions. I will fix the issues in proper XML under make-keyboard-text and put the PR in Gitlab.
For bn_* I can test and confirm. But for Assamese, need someone who speaks/writes it.