sdl_java_suite icon indicating copy to clipboard operation
sdl_java_suite copied to clipboard

WIP: Feature / remove handler from sdl remote display

Open BrettyWhite opened this issue 7 years ago • 1 comments

WIP

Fixes #858

This PR is not ready for review.

Risk

This PR makes no API changes.

Testing Plan

[Describe how you plan to unit test the changes in this PR]

Summary

Handle keep alive logic in the encoder. This will be updated and fixed in a future release

CLA

BrettyWhite avatar Sep 06 '18 14:09 BrettyWhite

Codecov Report

Merging #859 into develop will increase coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #859      +/-   ##
=============================================
+ Coverage      44.63%   44.64%   +0.01%     
- Complexity      3187     3189       +2     
=============================================
  Files            399      399              
  Lines          18196    18220      +24     
  Branches        1761     1765       +4     
=============================================
+ Hits            8121     8135      +14     
- Misses          9745     9751       +6     
- Partials         330      334       +4
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 4.64% <0%> (-0.01%) 6 <0> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 30.24% <50%> (+5.53%) 10 <2> (+2) :arrow_up:
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 63.33% <66.66%> (+0.09%) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5deff97...419df42. Read the comment docs.

codecov-io avatar Sep 06 '18 14:09 codecov-io