sdl_java_suite
sdl_java_suite copied to clipboard
Feature/issue 595 - Progress Bar Seek Feature
Fixes #595
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
- Updated the current unit tests and added new ones to test OnSeekMediaClockTimer.
Summary
This PR implements the progress bar seek feature as described in the proposal.
CLA
- [x] I have signed the CLA
Codecov Report
Merging #749 into develop will decrease coverage by
0.2%. The diff coverage is30.23%.
@@ Coverage Diff @@
## develop #749 +/- ##
=============================================
- Coverage 41.01% 40.81% -0.21%
- Complexity 2643 2652 +9
=============================================
Files 362 363 +1
Lines 15853 16035 +182
Branches 1695 1723 +28
=============================================
+ Hits 6502 6544 +42
- Misses 9044 9186 +142
+ Partials 307 305 -2
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...n/java/com/smartdevicelink/proxy/SdlProxyBase.java | 5.32% <0%> (-0.05%) |
6 <0> (ø) |
|
| ...com/smartdevicelink/protocol/enums/FunctionID.java | 89.89% <100%> (+0.1%) |
8 <0> (ø) |
:arrow_down: |
| .../smartdevicelink/proxy/rpc/SetMediaClockTimer.java | 100% <100%> (ø) |
10 <2> (+2) |
:arrow_up: |
| ...a/com/smartdevicelink/proxy/RPCRequestFactory.java | 79.61% <25%> (-0.48%) |
64 <0> (ø) |
|
| ...artdevicelink/proxy/rpc/OnSeekMediaClockTimer.java | 70% <70%> (ø) |
4 <4> (?) |
|
| ...smartdevicelink/encoder/VirtualDisplayEncoder.java | 24.71% <0%> (-4.6%) |
8% <0%> (ø) |
|
| ...va/com/smartdevicelink/transport/TCPTransport.java | 0% <0%> (ø) |
0% <0%> (ø) |
:arrow_down: |
| ...main/java/com/smartdevicelink/proxy/RPCStruct.java | 77.11% <0%> (+0.84%) |
38% <0%> (+1%) |
:arrow_up: |
| ...ava/com/smartdevicelink/proxy/SdlProxyBuilder.java | 63.55% <0%> (+17.71%) |
2% <0%> (+1%) |
:arrow_up: |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update e0f940b...d9ea6ac. Read the comment docs.