sdl_core icon indicating copy to clipboard operation
sdl_core copied to clipboard

Add missed setup of last_processed_event_

Open LitvinenkoIra opened this issue 8 years ago • 8 comments

  • UPDATE_NEEDED is sent if user requested PTU from HMI Main problem that it is the only one case when we should not send notification about update needed on HMI.
  • This notification is sends in callback of starting PT exchange. And to avoid sending this notification we need have information about trigger of UPDATE_NEEDED state, so why do we added new variable to store last status.
  • If SDL stores last status it is possible to check if PTU was triggered by user request, or not.

And in this PR I add missed last_processed_event_ key setup from changes related to "Fix UPDATE_NEEDED is sent if user requested PTU from HMI". #1491

LitvinenkoIra avatar Jun 15 '17 14:06 LitvinenkoIra

@LuxoftAKutsan @dev-gh @AByzhynar @AKalinich-Luxoft please review

LitvinenkoIra avatar Jun 15 '17 14:06 LitvinenkoIra

ATF failed http://opensdl-jenkins.luxoft.com:8080/job/OpenSDL_Develop_PR/job/OpenSDL_develop_ATF/348/

JenkinsSDLOnCloud avatar Jun 15 '17 15:06 JenkinsSDLOnCloud

@LitvinenkoIra Please write PR description that gives answers to:

  • what was the issue? (E.g. 'SDL sends same update status twice')
  • what was done to resolve the issue (E.g. 'Added new variable to store last status')
  • why it was done in that way? (E.g. 'If SDL stores last status it is possible to check whether next event changes status to same or another value')

Currently you just describe obvious things seen from code difference but w/o any understanding what for and why.

dev-gh avatar Jun 19 '17 10:06 dev-gh

@LitvinenkoIra please specify more clearly what was the defect and root cause.

LuxoftAKutsan avatar Jun 19 '17 11:06 LuxoftAKutsan

@dev-gh @LuxoftAKutsan updated description

LitvinenkoIra avatar Jun 19 '17 14:06 LitvinenkoIra

Can one of the admins verify this patch?

JenkinsSDLOnCloud avatar Oct 07 '17 08:10 JenkinsSDLOnCloud

Can one of the admins verify this patch?

JenkinsSDLOnCloud avatar Oct 10 '17 16:10 JenkinsSDLOnCloud

Can one of the admins verify this patch?

JenkinsSDLOnCloud avatar Oct 13 '17 10:10 JenkinsSDLOnCloud