rpc_spec icon indicating copy to clipboard operation
rpc_spec copied to clipboard

rpc_spec should include a list of the reserved keywords

Open bilal-alsharifi opened this issue 5 years ago • 4 comments

rpc_spec module should include a list of the reserved keywords for all platforms (iOS, Java Suite, JavaScript suite) so when RPC generators, in the mentioned platforms, try to generate RPCs, they avoid using the reserved keywords.

bilal-alsharifi avatar Mar 23 '20 15:03 bilal-alsharifi

@theresalech @joeygrover @TinaKleczka @mrapitis because it impacts all related platforms, should it be included as revision in the SDL-0234 proposal and considered on SDLC?

The generator changes were requested in:

  • Android: https://github.com/smartdevicelink/sdl_java_suite/pull/1273#issuecomment-604060225
  • iOS: https://github.com/smartdevicelink/sdl_ios/pull/1556#issuecomment-604077017
  • JavaScript: https://github.com/smartdevicelink/sdl_javascript_suite/issues/2#issuecomment-604071918

vladmu avatar Mar 26 '20 09:03 vladmu

Hi @vladmu yes, we will enter a proposal to revise SDL 0234 to account for these changes. Given the time constraints around the upcoming releases, we'd greatly appreciate any assistance Luxoft can provide in expediting development of this change in the proxy libraries once the proposal revisions have been reviewed/accepted by the Steering Committee. Thank you!

theresalech avatar Mar 26 '20 14:03 theresalech

@theresalech, we will need to follow the proper protocol. At this time I would ask that the Author make revisions to the current proposal and present the changes in the SDLC Committee Meeting and allow the members to vote upon the revisions to assure this will be an agreed upon revision across the committee members. Thank you

TinaKleczka avatar Mar 26 '20 15:03 TinaKleczka

Hi @TinaKleczka - absolutely. We'll be entering a proposal to make revisions to SDL 0234, which will be presented to the Steering Committee and voted upon under the standard SDL Evolution Process.

theresalech avatar Mar 26 '20 18:03 theresalech