hardhat-starter-kit icon indicating copy to clipboard operation
hardhat-starter-kit copied to clipboard

Rename "PRIVATE_KEY" variable to "WALLET_PRIVATE_KEY"

Open jule64 opened this issue 2 years ago • 4 comments

I've just spent 1 hour in a Chainlink workshop struggling to start up hardhat because I assumed this variable was for the infura/alchemy private key.. I kept getting these "private key too short" error messages and even the bootcamp people didn't realise what the issue was. Using a more explicit name for this variable could resolve any confusion as I imagine others might have faced this too..

jule64 avatar Mar 10 '23 12:03 jule64

Can I work on this issue ?

naman1402 avatar May 04 '23 12:05 naman1402

@NamanMohnani, of course, go for it! Thanks for raising this issue, @jule64

andrejrakic avatar May 04 '23 12:05 andrejrakic

@andrejrakic Apparently I can not make changes in the .env file, am I supposed to make changes in the .env.example file ?

naman1402 avatar May 04 '23 13:05 naman1402

@andrejrakic I've submitted my PR kindly check on it.

naman1402 avatar May 07 '23 05:05 naman1402