external-adapters-js icon indicating copy to clipboard operation
external-adapters-js copied to clipboard

Update test-payload.json for EAs. pt 1

Open karen-stepanyan opened this issue 2 years ago • 3 comments

Part 1 of DF-18523

Although this is just the first part, there are lot of file changes, but changes are repetitive. In particular each EA folder has 3 changes

  1. new entries are added into test-payload.json. These new entries are mostly the same payloads but with endpoint names and aliases. This makes sure that for every endpoint+aliases we have configuration for soak testing.
  2. new unit test is added (either in existing file or in a new file) that ensures that test-payload.json always contains requests with all endpoints+aliases. If new endpoint is added/updated and test-paylaod is not updated, unit test will fail
  3. tsconfig.test.json is updated to include test-payload.json so that the test file can import test-payload.json

karen-stepanyan avatar Nov 14 '23 17:11 karen-stepanyan

⚠️ No Changeset found

Latest commit: c0cc87f39c3f19c5a85090c75185e1a8442326bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 14 '23 17:11 changeset-bot[bot]

The code itself looks great, it's clear you were careful with the set of endpoints and payloads for each adapter. Would you be able to resolve the conflicts, then let the soak test re-run and I can ✅ after that?

austinborn avatar Nov 23 '23 01:11 austinborn

hey @austinborn . soak testing isn't even running as there are too many changed adapters and Deploy phase is timing out.

karen-stepanyan avatar Nov 23 '23 11:11 karen-stepanyan

Felt there is a lot of repetitive code here, not sure if there is a way to extract this and have this test automatically run on each adapter

mxiao-cll avatar Jul 11 '24 13:07 mxiao-cll

See the ticket in the description

karen-stepanyan avatar Jul 12 '24 14:07 karen-stepanyan