chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Audit Logs Rebase

Open obelisk opened this issue 3 years ago • 3 comments

This rebases the audit log system originally written by @CL-Andrew to be on top of all the new code as well as addressing open issues.

This is a move of PR #7428.

obelisk avatar Sep 15 '22 20:09 obelisk

Solana Smoke Test Results

1 tests   1 :heavy_check_mark:  4m 59s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit dad7e2e7.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 15 '22 21:09 github-actions[bot]

EVM Smoke Test Results

  1 files    1 suites   6m 17s :stopwatch: 82 tests 34 :heavy_check_mark: 48 :zzz: 0 :x: 83 runs  34 :heavy_check_mark: 49 :zzz: 0 :x:

Results for commit dad7e2e7.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 15 '22 21:09 github-actions[bot]

I've rewritten the configuration system so we have validation which is still private to the module. I've also removed lots of pointer uses to reduce crashes.

On the point of a Noop/NilLogger an empty struct currently fulfills this role pretty well and doesn't even start a subservice when not configured. Calls into it Audit get dropped easily as well.

obelisk avatar Sep 21 '22 02:09 obelisk