chore: remove waitBlocks > finality depth check
This check forces us to run with really low finality depths, which is not ideal on chains like Polygon. I don't much see the relationship between these two fields, since waitBlocks is used to determine the block number range we provide for an eventual eth_getLogs RPC call.
I see that you haven't updated any CHANGELOG files. Would it make sense to do so?
Solana Smoke Test Results
1 tests 1 :heavy_check_mark: 4m 39s :stopwatch: 1 suites 0 :zzz: 1 files 0 :x:
Results for commit a32412ab.
:recycle: This comment has been updated with latest results.
EVM Smoke Test Results
52 tests 22 :heavy_check_mark: 6m 17s :stopwatch: 1 suites 30 :zzz: 1 files 0 :x:
Results for commit a32412ab.
:recycle: This comment has been updated with latest results.
If waitBlocks < finalityDepth, wouldn't the feeder store unfinalized blocks in BHS?
I think I need to hear an explanation of this, because I don't think I follow the reasoning.
Will close this as it's no longer really a problem.