chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

chore: remove waitBlocks > finality depth check

Open makramkd opened this issue 3 years ago • 4 comments

This check forces us to run with really low finality depths, which is not ideal on chains like Polygon. I don't much see the relationship between these two fields, since waitBlocks is used to determine the block number range we provide for an eventual eth_getLogs RPC call.

makramkd avatar Sep 12 '22 17:09 makramkd

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Sep 12 '22 17:09 github-actions[bot]

Solana Smoke Test Results

1 tests   1 :heavy_check_mark:  4m 39s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit a32412ab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 12 '22 17:09 github-actions[bot]

EVM Smoke Test Results

52 tests   22 :heavy_check_mark:  6m 17s :stopwatch:   1 suites  30 :zzz:   1 files      0 :x:

Results for commit a32412ab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 12 '22 17:09 github-actions[bot]

If waitBlocks < finalityDepth, wouldn't the feeder store unfinalized blocks in BHS?

I think I need to hear an explanation of this, because I don't think I follow the reasoning.

makramkd avatar Sep 15 '22 05:09 makramkd

Will close this as it's no longer really a problem.

makramkd avatar Sep 29 '22 17:09 makramkd