chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Feature: sui keystore

Open faisal-chainlink opened this issue 8 months ago • 4 comments

Adds the Sui keystore to core

Requires

  • https://github.com/smartcontractkit/chain-selectors/pull/117

faisal-chainlink avatar May 07 '25 16:05 faisal-chainlink

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions[bot] avatar May 09 '25 10:05 github-actions[bot]

Flakeguard Summary

Ran new or updated tests between develop and 2515808661dfd5aa6be4d254c62a569f8565ddfd (feature/sui-keystore).

View Flaky Detector Details | Compare Changes

Found Flaky Tests :x:

12 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestShell_SuiKeys 0% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/cmd true 0s Unknown
TestShell_SuiKeys/ListSuiKeys 0% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/cmd true 860ms Unknown
Test_SuiKeyStore_E2E/adds_an_externally_created_key_/_deletes_a_key 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/keystore true 0s @smartcontractkit/foundations, @smartcontractkit/core
Test_SuiKeyStore_E2E/imports_and_exports_a_key 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/services/keystore true 0s @smartcontractkit/foundations, @smartcontractkit/core
TestETHKeysController_ChainFailure_InvalidEnabled 66.6667% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.47s Unknown
TestSuiKeysController_Create_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.466666666s Unknown
TestSuiKeysController_Delete_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 120ms Unknown
TestSuiKeysController_Delete_NonExistentSuiKeyID 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 140ms Unknown
TestSuiKeysController_Index_HappyPath 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web false 123.333333ms Unknown
TestResolver_SuiKeys/no_keys_returned_by_GetAll 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 113.333333ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core
TestResolver_SuiKeys/not_authorized 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 110ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core
TestResolver_SuiKeys/success 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/web/resolver false 83.333333ms @smartcontractkit/deployment-automation, @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

github-actions[bot] avatar May 15 '25 18:05 github-actions[bot]

Dependency PR: https://github.com/smartcontractkit/chainlink-protos/pull/79

stackman27 avatar Jun 09 '25 03:06 stackman27

Quality Gate failed Quality Gate failed

Failed conditions
15.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

addressed https://github.com/smartcontractkit/chainlink/pull/19848

stackman27 avatar Oct 14 '25 19:10 stackman27