smartcontractkit
the function in smartcontract maybe need to update?
Description I noticed a function in 'MockV3Aggregator.sol' file, the details as below:
function description() external pure override returns (string memory) { return "v0.8/tests/MockV3Aggregator.sol"; }
But I checked the "MockV3Aggregator.sol" 's path in the project, the real path is: "v8.0/shared/mocks/MockV3Aggregator.sol"
So do we need to change it to like this:
function description() external pure override returns (string memory) { return "v8.0/shared/mocks/MockV3Aggregator.sol"; }
use "v8.0/shared/mocks/MockV3Aggregator.sol" replace "v0.8/tests/MockV3Aggregator.sol"
best regards
Hi, I'd like to work on this issue. Please assign it to me if it's available. Let me know if there's anything specific you'd like me to follow while fixing it. Thanks!
yes, sir you can refer to my codes on this page, i have published all of this. and yes, i tested it through this solution in my local env it is available good
if you have any questions after you checked my publish on this page please let me know i could share my github about this detail codes.
best regards
---Original--- From: "Yash @.> Date: Sun, Jun 1, 2025 22:12 PM To: @.>; Cc: @.@.>; Subject: Re: [smartcontractkit/chainlink] the function in smartcontract maybeneed to update? (Issue #17267)
singhyash05 left a comment (smartcontractkit/chainlink#17267)
Hi, I'd like to work on this issue. Please assign it to me if it's available. Let me know if there's anything specific you'd like me to follow while fixing it. Thanks!
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
why not Do you need me to do anything to help you arrive this?
---Original--- From: "Yash @.> Date: Sun, Jun 1, 2025 23:50 PM To: @.>; Cc: @.@.>; Subject: Re: [smartcontractkit/chainlink] the function in smartcontract maybeneed to update? (Issue #17267)
singhyash05 left a comment (smartcontractkit/chainlink#17267)
Can I work on this Issue?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
OK，copy that
---Original--- From: "Yash @.> Date: Mon, Jun 2, 2025 01:08 AM To: @.>; Cc: @.@.>; Subject: Re: [smartcontractkit/chainlink] the function in smartcontract maybeneed to update? (Issue #17267)
singhyash05 left a comment (smartcontractkit/chainlink#17267)
No I will work on this and if i need your help surely ask you.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
Hi, I've submitted a [PR for this issue: #18059 ](fix: update description path in MockV3Aggregator.sol #18059)
It updates the description() function in MockV3Aggregator.sol to reflect the correct file path.
Let me know if any changes are needed. Thanks!
