chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

[BCI-3988] - FilteredLogs receive []Expression instead of whole KeyFilter

Open Farber98 opened this issue 1 year ago • 1 comments

Task Description:

Log poller Filtered logs have no use for Key, which makes the method confusing when used outside of CR

This PR:

  • Modify FilteredLogs method so it receives []query.Expression instead of whole query.KeyFilter as param.
  • Fix references.

Ticket:

Note:

  • ~https://github.com/smartcontractkit/chainlink/pull/14096 will introduce small conflicts as it adds a new reference to FilteredLogs~ fixed

Farber98 avatar Aug 13 '24 17:08 Farber98

@patrick-dowell

What impact will this PR have on CCIP? Just want to make sure we are mindful of the concerns Makram raised. My other comments were mostly questions as I don't know much about how these expressions work.

Mateusz commented here the following:

we keep merging chainlink repository every 2-3 weeks so if you merge that in the upstream we will get that eventually. No need to create a PR in ccip repo unless it's super critical for CCIP to have

We only need to merge core and they will eventually get these changes. We only cherry pick when changes needed are urgent as Makram said here too

Farber98 avatar Sep 04 '24 19:09 Farber98