[BCI-3988] - FilteredLogs receive []Expression instead of whole KeyFilter
Task Description:
Log poller Filtered logs have no use for Key, which makes the method confusing when used outside of CR
This PR:
- Modify
FilteredLogsmethod so it receives[]query.Expressioninstead of wholequery.KeyFilteras param. - Fix references.
Ticket:
Note:
- ~https://github.com/smartcontractkit/chainlink/pull/14096 will introduce small conflicts as it adds a new reference to
FilteredLogs~ fixed
Quality Gate passed
Issues
0 New issues
1 Fixed issue
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
2.4% Duplication on New Code
@patrick-dowell
What impact will this PR have on CCIP? Just want to make sure we are mindful of the concerns Makram raised. My other comments were mostly questions as I don't know much about how these expressions work.
Mateusz commented here the following:
we keep merging chainlink repository every 2-3 weeks so if you merge that in the upstream we will get that eventually. No need to create a PR in ccip repo unless it's super critical for CCIP to have
We only need to merge core and they will eventually get these changes. We only cherry pick when changes needed are urgent as Makram said here too