chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard

Move txmgr in evm package

Open dimriou opened this issue 1 year ago • 3 comments

In order to degeneralize the TXM, first we have to degeneralize txmgr.go and move it under evm package so we can slowly rollout each subcomponent separately. Since generalized and non-generalized subcomponents are mixed at the moment, we have to keep generics for the time being and remove them as we degeneralize each subcomponent.

dimriou avatar May 21 '24 12:05 dimriou

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions[bot] avatar May 21 '24 12:05 github-actions[bot]

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 21 '24 00:07 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 21 '24 00:09 github-actions[bot]