chainlink icon indicating copy to clipboard operation
chainlink copied to clipboard
verified publisher icon smartcontractkit

bump geth v1.14.7; rm hack

Open jmank88 opened this issue 2 years ago • 8 comments

https://smartcontract-it.atlassian.net/browse/BCF-3338

Bumping geth to v1.14.7, which brings a new simulated backend API from v1.13.14 and breaks our usage of the old one.

Failing Tests

These tests are currently skipped due to disruptive failures. All need to be fixed before merging:

package core/chains/evm/headtracker

head_tracker_test.go

  • [x] TestHeadTracker_CallsHeadTrackableCallbacks(t *testing.T) {

package core/chains/evm/log

integration_test.go

  • [x] TestBroadcaster_InjectsBroadcastRecordFunctions(t *testing.T) {
  • [x] TestBroadcaster_ProcessesLogsFromReorgsAndMissedHead(t *testing.T) {
  • [x] TestBroadcaster_BackfillsForNewListeners(t *testing.T) {
  • [x] TestBroadcaster_BroadcastsWithZeroConfirmations(t *testing.T) {

package core/internal/features

features_test.go

  • [ ] TestIntegration_DirectRequest(t *testing.T) {
  • [ ] TestIntegration_AsyncEthTx(t *testing.T) {
  • [ ] TestIntegration_OCR(t *testing.T) {
  • [ ] TestIntegration_OCR_ForwarderFlow(t *testing.T) {

package core/internal/features/ocr2

features_ocr2_plugin_test.go

  • [ ] TestIntegration_OCR2_plugins(t *testing.T) {

features_ocr2_test.go

  • [ ] TestIntegration_OCR2(t *testing.T) {
  • [ ] TestIntegration_OCR2_ForwarderFlow(t *testing.T) {

package core/services/fluxmonitorv2

integrations_test.go

  • [ ] TestFluxMonitor_Deviation(t *testing.T) {
  • [ ] TestFluxMonitor_NewRound(t *testing.T) {
  • [ ] TestFluxMonitor_HibernationMode(t *testing.T) {
  • [ ] TestFluxMonitor_InvalidSubmission(t *testing.T) {
  • [ ] TestFluxMonitorAntiSpamLogic(t *testing.T) {

package core/services/keeper

integration_test.go

  • [ ] TestKeeperEthIntegration(t *testing.T) {
  • [ ] TestKeeperForwarderEthIntegration(t *testing.T) {
  • [ ] TestMaxPerformDataSize(t *testing.T) {

package core/services/ocr2/plugins/functions/integration_tests/v1

functions_integration_test.go

  • [ ] TestIntegration_Functions_MultipleV1Requests_Success(t *testing.T) {
  • [ ] TestIntegration_Functions_MultipleV1Requests_ThresholdDecryptionSuccess(t *testing.T) {
  • [ ] TestIntegration_Functions_MultipleV1Requests_WithUpgrade(t *testing.T) {

package core/services/ocr2/plugins/llo

onchain_channel_definition_cache_integration_test.go

  • [ ] Test_ChannelDefinitionCache_Integration(t *testing.T) {

package core/services/ocr2/plugins/mercury

integration_plugin_test.go

  • [ ] TestIntegration_MercuryV1_Plugin(t *testing.T) {
  • [ ] TestIntegration_MercuryV2_Plugin(t *testing.T) {
  • [ ] TestIntegration_MercuryV3_Plugin(t *testing.T) {

integration_test.go

  • [ ] integration_MercuryV1(t *testing.T) {
  • [ ] TestIntegration_MercuryV2(t *testing.T) {
  • [ ] TestIntegration_MercuryV3(t *testing.T) {

package core/services/ocr2/plugins/ocr2keeper

integration_21_test.go

  • [ ] TestIntegration_KeeperPluginConditionalUpkeep(t *testing.T) {
  • [ ] TestIntegration_KeeperPluginLogUpkeep(t *testing.T) {
  • [ ] TestIntegration_KeeperPluginLogUpkeep_Retry(t *testing.T) {
  • [ ] TestIntegration_KeeperPluginLogUpkeep_ErrHandler(t *testing.T) {

integration_test.go

  • [ ] TestIntegration_KeeperPluginForwarderEnabled(t *testing.T) {

package core/services/relay/evm

chain_reader_test.go

  • [ ] TestChainReader(t *testing.T) {

package core/services/relay/evm/mercury

config_poller_test.go

  • [ ] TestMercuryConfigPoller(t *testing.T) {

package core/services/vrf/solidity_cross_tests

vrf_request_cost_test.go

  • [ ] TestMeasureRandomnessRequestGasCost(t *testing.T) {

package core/services/vrf/v1

integration_test.go

  • [ ] TestIntegration_VRF_WithBHS(t *testing.T) {

package core/services/vrf/v2

bhs_feeder_test.go

  • [ ] TestStartHeartbeats(t *testing.T) {

integration_v2_plus_test.go

  • [ ] TestVRFV2PlusIntegration_SingleConsumer_EIP150_HappyPath(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_SingleConsumer_BigGasCallback_Sandwich(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_SingleConsumer_MultipleGasLanes(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_SingleConsumer_AlwaysRevertingCallback_StillFulfilled(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_ConsumerProxy_HappyPath(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_TestMaliciousConsumer(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_Migration(t *testing.T) {
  • [ ] TestVRFV2PlusIntegration_ReplayOldRequestsOnStartUp(t *testing.T) {

integration_v2_reverted_txns_test.go

  • [ ] TestVRFV2Integration_SingleRevertedTxn_ForceFulfillment(t *testing.T) {
  • [ ] TestVRFV2Integration_BatchRevertedTxn_ForceFulfillment(t *testing.T) {
  • [ ] TestVRFV2Integration_ForceFulfillmentRevertedTxn_Retry(t *testing.T) {
  • [ ] TestVRFV2Integration_CanceledSubForceFulfillmentRevertedTxn_Retry(t *testing.T) {

integration_v2_test.go

  • [ ] TestVRFV2Integration_SingleConsumer_ForceFulfillment(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_ForceFulfillment_BatchEnabled(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_HappyPath_BatchFulfillment(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_HappyPath_BatchFulfillment_BigGasCallback(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_HappyPath(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_EIP150_Revert(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_Wrapper(t *testing.T) {
  • [ ] TestVRFV2Integration_Wrapper_High_Gas(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_NeedsBlockhashStore(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_NeedsTrustedBlockhashStore(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_NeedsTrustedBlockhashStore_AfterDelay(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_BlockHeaderFeeder(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_NeedsTopUp(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_BigGasCallback_Sandwich(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_MultipleGasLanes(t *testing.T) {
  • [ ] TestVRFV2Integration_SingleConsumer_AlwaysRevertingCallback_StillFulfilled(t *testing.T) {
  • [ ] TestVRFV2Integration_ConsumerProxy_HappyPath(t *testing.T) {
  • [ ] TestIntegrationVRFV2(t *testing.T) {
  • [ ] TestMaliciousConsumer(t *testing.T) {
  • [ ] TestRequestCost(t *testing.T) {
  • [ ] TestMaxConsumersCost(t *testing.T) {
  • [ ] TestFulfillmentCost(t *testing.T) {
  • [ ] TestVRFV2Integration_ReplayOldRequestsOnStartUp(t *testing.T) {

listener_v2_log_listener_test.go

  • [ ] TestInitProcessedBlock_NoVRFReqs(t *testing.T) {
  • [ ] TestInitProcessedBlock_NoUnfulfilledVRFReqs(t *testing.T) {
  • [ ] TestInitProcessedBlock_OneUnfulfilledVRFReq(t *testing.T) {
  • [ ] TestInitProcessedBlock_SomeUnfulfilledVRFReqs(t *testing.T) {
  • [ ] TestInitProcessedBlock_UnfulfilledNFulfilledVRFReqs(t *testing.T) {
  • [ ] TestUpdateLastProcessedBlock_NoVRFReqs(t *testing.T) {
  • [ ] TestUpdateLastProcessedBlock_NoUnfulfilledVRFReqs(t *testing.T) {
  • [ ] TestUpdateLastProcessedBlock_OneUnfulfilledVRFReq(t *testing.T) {
  • [ ] TestUpdateLastProcessedBlock_SomeUnfulfilledVRFReqs(t *testing.T) {
  • [ ] TestUpdateLastProcessedBlock_UnfulfilledNFulfilledVRFReqs(t *testing.T) {

jmank88 avatar Jan 18 '24 14:01 jmank88

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

github-actions[bot] avatar Jan 18 '24 14:01 github-actions[bot]

@jmank88 please do not merge until I run go-ethereum-as-a-server compatibility tests for it, ok?

Tofel avatar Mar 13 '24 15:03 Tofel

@jmank88 alles verden machen! at least for commit 38f64e0bc6247ab9e52f2d358a7469d55d1cefab ---> results

Preview: image

Tofel avatar Mar 14 '24 09:03 Tofel

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
2.8% Coverage on New Code
5.2% Duplication on New Code

See analysis details on SonarQube

cl-sonarqube-production[bot] avatar Apr 03 '24 17:04 cl-sonarqube-production[bot]

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

:medal_military: No JIRA issue number found - Please include it in the PR title or in a commit message.

github-actions[bot] avatar May 14 '24 21:05 github-actions[bot]

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

cl-sonarqube-production[bot] avatar May 15 '24 03:05 cl-sonarqube-production[bot]

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube

cl-sonarqube-production[bot] avatar Jul 10 '24 23:07 cl-sonarqube-production[bot]