ccip icon indicating copy to clipboard operation
ccip copied to clipboard

Multi-OffRamp - MultiCommitStore integration & coverage

Open elatoskinas opened this issue 1 year ago • 2 comments

Motivation

Integrates the MultiCommitStore, addresses TODOs to address lane-specific logic and improves test coverage

Solution

  • Optimization: remove event indexing for Skipped events (since there are no strong use-cases for observability / users)
  • Add source chain selector to RMN Cursing and SkippedAlreadyExecuted event
  • Validate 0 chain selector
  • Additional test coverage (+ AlreadyAttempted for OffRamp and MultiOffRamp test case)

elatoskinas avatar May 17 '24 09:05 elatoskinas

LCOV of commit 45c3b2c during Solidity Foundry #4647

Summary coverage rate:
  lines......: 98.7% (1256 of 1273 lines)
  functions..: 96.4% (266 of 276 functions)
  branches...: 91.9% (511 of 556 branches)

Files changed coverage rate: n/a

github-actions[bot] avatar May 17 '24 09:05 github-actions[bot]

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

github-actions[bot] avatar May 22 '24 14:05 github-actions[bot]