ccip icon indicating copy to clipboard operation
ccip copied to clipboard

[DEVEL] CCIP Receiver incompatibility with AccessControlDefaultAdminRules from OpenZeppelin

Open RyanHolanda opened this issue 1 year ago • 0 comments

Description The CCIPReceive abstract contract is incompatible with the AccessControlDefaultAdminRules from OpenZeppelin, when implementing both, we need to override the supportsInterface(bytes4) function, but they have different state mutability, CCIPReceive uses pure, and AccessControlDefaultAdminRules uses view. So we can't override it and use super.supportsInterface(bytes4) for example

Steps to Reproduce

  1. Implement CCIP Receive (Latest Version)
  2. Implement AccessControlDefaultAdminRules (Latest Version)

Additional Information Perhaps change the state mutability to view? because pure can override view, but the inverse is not possible

RyanHolanda avatar May 13 '24 21:05 RyanHolanda