ccip icon indicating copy to clipboard operation
ccip copied to clipboard

Let USDC look for the exact nonce instead of relying on ordering

Open RensR opened this issue 1 year ago • 2 comments

Motivation

We don't want to have the offchain code be reliant on onchain ordering of events.

Solution

Since we only relied on the ordering of USDC events, we can solve the dependency by removing the ordering requirement for USDC. With this new method we look for the exact nonce, which is significantly less brittle overal. It should not care about log ordering, so we can remove the comment from the onRamps

RensR avatar Jun 14 '24 13:06 RensR

LCOV of commit da1ba26 during Solidity Foundry #5441

Summary coverage rate:
  lines......: 98.9% (1478 of 1495 lines)
  functions..: 95.8% (297 of 310 functions)
  branches...: 93.1% (639 of 686 branches)

Files changed coverage rate: n/a

github-actions[bot] avatar Jun 14 '24 13:06 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Sep 14 '24 00:09 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 01 '24 00:11 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Nov 12 '24 00:11 github-actions[bot]