smallrye-graphql icon indicating copy to clipboard operation
smallrye-graphql copied to clipboard
verified publisher icon smallrye

Added default name for non-runtime included parameters (for JANDEX API), client-side

Open mskacelik opened this issue 1 year ago • 1 comments

/cc @jmartisk fixes: #2111 Added a default name for parameters not configured to be part of the runtime. The default names are equivalent to the Java Reflection API names (arg0, arg1, arg2,...), so they can be consistent in the GraphQL Request building phase.

I am unsure if tests are necessary since I don't think we have tests for such cases, but I can make them if you wish.

mskacelik avatar May 18 '24 17:05 mskacelik

Not really sure why Quarkus's tests failed

mskacelik avatar May 18 '24 19:05 mskacelik

@mskacelik isn't that because the CI tests are still configured to run against your 2.8.2 branch? https://github.com/smallrye/smallrye-graphql/blob/c757c099162d8d4674e7884418693375c990cc33/.github/workflows/build.yml#L99 could you try switching it to the official Quarkus main?

jmartisk avatar May 20 '24 08:05 jmartisk