smallrye-graphql icon indicating copy to clipboard operation
smallrye-graphql copied to clipboard

DRAFT: Additional features for graphql federation

Open johgoe opened this issue 4 years ago • 1 comments

This pull request should only publish some changes, which we did in our project to get some additional federation features. It's not tested yet because on quarkus we did some additional changes like the generation of an additional jandex index, which shouldn't be required for normal application servers like a wildfly. Maybe our changes can be a inspiration for smallrye-graphql federation support.

  • Add support for GraphQLInterfaces
  • Allow primitive types as parameters in resolver methods
  • Allow mutiny! returns

johgoe avatar Oct 29 '21 06:10 johgoe

Cool that you made it work! I yet had it working for some demos only. My current approach is completely different, though: it's based on https://github.com/apollographql/federation-jvm, i.e. that lib does all the heavy lifting. You may want to take a look at the PR #1132. The only thing still missing is adding the fetcher and resolver and I'm going to work on that right now.

t1 avatar Oct 29 '21 12:10 t1

@t1 - can you look at this ?

phillip-kruger avatar Sep 29 '22 23:09 phillip-kruger

This is based on the old approach which was completely different to what we did in #521, which ist based on federation-graphql-java-support. I haven't tested it, but the requirements for this ticket may very well already have been addressed. I think we can close this. WDYT, @johgoe?

t1 avatar Sep 30 '22 09:09 t1

I also think this PR is obsolete. I think the new approach already covers the most of these changes.

johgoe avatar Sep 30 '22 18:09 johgoe