smallrye-common icon indicating copy to clipboard operation
smallrye-common copied to clipboard

Save StringConcat bytecode generation for one-time operation

Open franz1981 opened this issue 1 year ago • 3 comments

This has popup as a bytecode generation operation which can both save memory and CPU time at startup, see

image

It both save the lambda generation and, most importantly, a useless string concatenation.

franz1981 avatar Jun 22 '24 13:06 franz1981

Why not just eliminate the string concatenation and keep the lambda? Keeping the lambda means one less class to load from disk.

dmlloyd avatar Jun 24 '24 15:06 dmlloyd

@dmlloyd I have no strong opinion on this, so I can do it like that as well

franz1981 avatar Jun 24 '24 18:06 franz1981

:+1: it's probably better to keep the fix down to the thing being fixed when possible.

dmlloyd avatar Jun 24 '24 18:06 dmlloyd

@radcortez similar to the others we know about ^^

franz1981 avatar Nov 12 '24 17:11 franz1981

I actually independently came up with https://github.com/smallrye/smallrye-common/pull/388

geoand avatar Jan 16 '25 14:01 geoand

Closed in favor of #388.

radcortez avatar Jan 19 '25 10:01 radcortez