Jonathan Chang
Jonathan Chang
Agree on everything.
Alright, this PR now up-to-date. @drewsonne , do you think this PR is still worthwhile.
There are some changes requested on that PR. If you have the bandwidth to update it with the requested changes, I'd be happy to merge!
Just to check, you don't try the second connection until after onRoomDidDisconnect is fired right? Afaik, that's the only signal twilio gives us that whatever it needs to do is...
Do you get a successful onRoomDidConnect? Does the order in which participants connect seem to affect the outcome?
Weird, could you add a log here: https://github.com/blackuy/react-native-twilio-video-webrtc/blob/master/android/src/main/java/com/twiliorn/library/CustomTwilioVideoView.java#L746 to see what exception is being thrown? It might also be in the logcat logs if you can dig them up.
Hi @neildevas, thanks for those details, that really helps. Would you be comfortable setting a breakpoint at line 392 of CustomTwilioVideoView.java? Because events are firing twice, it seems like there...
@saghul Oof, sorry, posted on the wrong repo. I'll delete my message and try to get some sleep =0.
It's been many years since I did this, but you can read more about method swizzling here: https://nshipster.com/method-swizzling/ Just apply that to setCategory on AVAudioSession and ignore any calls that...
Looks like a reasonable change, feel free to throw up a PR and I'll make sure to merge it down.