sloth icon indicating copy to clipboard operation
sloth copied to clipboard

Consider support the Bad metrics from OpenSLO

Open weyert opened this issue 4 years ago • 2 comments

Recently the OpensLO added support to allow defining bad / totals metrics for SLO. See also this commit in OpensLO repo: https://github.com/OpenSLO/OpenSLO/commit/02257252e5d25b755d6285ee7bd4734ded9dd9cb

I was curious what's involved to add support for this into Sloth? Do you think this is achievable for someone who doesn't have any Go programming experience (me)?

weyert avatar Oct 27 '21 10:10 weyert

Hi @weyert!

Thanks for the update, we could add support indeed. You could give it a try indeed. I think that is not hard and a good exercise. I can point you to the place where this is happening (without telling you exactly so you can learn :smile:) and give it a shot.

If it's taking too much time or you are lost I can do it myself and explain the PR to you if you want.

For now... https://github.com/slok/sloth/tree/main/internal/openslo

slok avatar Nov 01 '21 10:11 slok

Thank you, @slok. Sounds like a plan!

weyert avatar Nov 01 '21 16:11 weyert