slim icon indicating copy to clipboard operation
slim copied to clipboard

Refactor `--http-probe-exec` and `--http-probe-exec-file` to be separate from HTTP probes and add its own `continue-after` mode

Open kcq opened this issue 4 years ago • 4 comments

These flags represent app probes that you configure to run when docker-slim is doing dynamic analysis. It should be done separately from the existing HTTP probes.

New names: --app-exec (was --http-probe-exec) --app-exec-file (was --http-probe-exec-file)

New continue-after mode: app

kcq avatar Dec 27 '21 03:12 kcq

Happy to work on it. I think it's a good one to become more familiar with the codebase. and the features.

rikez avatar Dec 28 '21 01:12 rikez

@rikez great! also happy to do a code walk through if you'd like :)

kcq avatar Dec 28 '21 01:12 kcq

Quick update: still working on that, will put a PR soon.

rikez avatar Jan 04 '22 05:01 rikez

Quick update: still working on that, will put a PR soon.

Any questions or thoughts? Let me know if you need any help.

kcq avatar Jan 04 '22 06:01 kcq