brew icon indicating copy to clipboard operation
brew copied to clipboard

Language strings aka. load_textdomain

Open quatroweb opened this issue 11 years ago • 3 comments

I noticed that the theme are using load_textdomain in stead of load_theme_textdomain

Is that something you have takken into concideration?

I got curious and actually counted the textdomains in the strings. I found about 10-11 different domains. Do you have plans to decrease these to just one or few to have a better overview of the language strings?

quatroweb avatar Mar 04 '14 08:03 quatroweb

What are your thoughts about the subject?

I tried to translate some few strings in the theme, but doesn't seem to work.

On the todo 1.0 list you wrote following:

  • Look in to combining functions.php/brew.php/bones.php

Are you planning to also clean up the language strings?

I also found more info here: http://codex.wordpress.org/Translating_WordPress

And here: https://codex.wordpress.org/I18n_for_WordPress_Developers

quatroweb avatar Mar 06 '14 07:03 quatroweb

I need to look in to this. All of the language strings are there as a result of me using Bones.

To be honest, I was considering pulling the code for the translation strings as I'll likely never use it in any project. If there's enough interest I can try and keep it/clean it up.

Looking around the bugs and messgaes on the Bones repository, it would appear that the translation files are incomplete and not completely understood by the author:

https://github.com/eddiemachado/bones/issues/400

https://github.com/eddiemachado/bones/issues/10

slightlyoffbeat avatar Mar 06 '14 08:03 slightlyoffbeat

I see what you mean.

In my opinion this really seems to be a good Bootstrap theme. I'm really interested in getting it to work properly for the language strings.

When or if you have in plans to do so, I will personally get the Portuguese (pt_BR) translation 100% done and send you the files to include them in your theme.

Could be a start though.

quatroweb avatar Mar 06 '14 08:03 quatroweb