secureli icon indicating copy to clipboard operation
secureli copied to clipboard

Logging should only be triggered when Secureli Scan is run from a pre-commit hook not from running via the scan command directly in the CLI

Open calebtonn opened this issue 2 years ago • 4 comments

As a SeCurLI user, I want logging to only be triggered when Secureli Scan is ran from a pre-commit hook and not from running via the scan command directly in the CLI   So that when logging is enabled, a scan action isn’t sent logs to observability API (can print locally) when called by CLI. This should only send send logs during pre-commit scan action, not manual CLI call of that action.

AC

calebtonn avatar Jul 31 '23 19:07 calebtonn

Need to refine this more with Caleb to get more information on the expected behavior.

dlolaogundipe avatar Jan 17 '24 18:01 dlolaogundipe

when logging is enabled, scan action shouldn't send logs to observability API (can print locally) when called by CLI. Should only send logs during pre-commit scan action, not manual CLI call of that action.

JordoHeffernan avatar Mar 14 '24 17:03 JordoHeffernan

This appears to be the existing functionality. Not sure when it was implemented, it very well may not have been the case when this ticket was submitted. But the current functionality is that publishing is set to never by default. You need to include --publish-results=always in order to publish results.

The pre-commit hook does have that parameter/value, and so results will always be published when secureli is run via the hook.

itoltz avatar Jun 05 '24 19:06 itoltz

Moving to done, as this issue was resolved at some point in the past.

itoltz avatar Jun 06 '24 16:06 itoltz