PanModal icon indicating copy to clipboard operation
PanModal copied to clipboard

Add ability to choose inset and visiablity for scroll view

Open Sc4pego4t opened this issue 5 years ago • 8 comments

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

  • [x ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • [ x] I've read and agree to the Code of Conduct.

  • [x ] I've written tests to cover the new code and functionality included in this PR.

Sc4pego4t avatar Jul 14 '20 11:07 Sc4pego4t

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Andrey Gluhih seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 14 '20 11:07 CLAassistant

Any update regarding this PR? ❤️

RuiAAPeres avatar Nov 02 '20 15:11 RuiAAPeres

yeah, I'm sorry, struggling with CLA signing. As I understood I should add commit with my email?

Sc4pego4t avatar Nov 02 '20 16:11 Sc4pego4t

image this page seems broken, I can't find any accept button(

Sc4pego4t avatar Nov 02 '20 16:11 Sc4pego4t

image What do you think can be a source of my problem with CLA? btw i see it in my setting in authorised apps

Sc4pego4t avatar Nov 02 '20 16:11 Sc4pego4t

I accidentally came across the same issue and this PR would come in really handy. @Sc4pego4t I'm rooting for you to get this merged 🙏

AivarasGus avatar Nov 04 '20 15:11 AivarasGus

@ste57 can you please help me? I've accepted policies, but merging is still blocked

Sc4pego4t avatar Nov 04 '20 15:11 Sc4pego4t

@AivarasGus @Sc4pego4t @ste57 created same pr with additional properties for tests and with license stuff fixed https://github.com/slackhq/PanModal/pull/121 if it's not possible to sign this one we can merge mine :)

simdani avatar Nov 04 '20 19:11 simdani